Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple commands in gateway binary #656

Merged
merged 7 commits into from
May 20, 2023
Merged

Support multiple commands in gateway binary #656

merged 7 commits into from
May 20, 2023

Conversation

pleshakov
Copy link
Contributor

@pleshakov pleshakov commented May 18, 2023 •
edited
Loading

This PR:

  • Adds the root command, which simply prints help.
  • Adds static-mode command, which starts NGINX Kubernetes Gateway in static mode --the previously available functionally of the gateway binary.
  • Adds provisioner-mode command, currently not implemented.

Needed by #634

@pleshakov pleshakov requested a review from a team as a code owner May 18, 2023 20:26
@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request labels May 18, 2023
@pleshakov pleshakov mentioned this pull request May 18, 2023
Closed
@pleshakov
Support multiple commands in gateway binary
7a1c05b 
This commit:
- Changes the cmd package to support multiple commands in
gateway binary.
- Adds the root command, which simply prints help.
- Adds control-plane command, which starts the control plane --
the previously available functionally of the gateway binary.
- Adds provisioner command, currently not implemented.

Needed by nginxinc#634
@pleshakov pleshakov force-pushed the feature/multiple-commands branch from 4ec3f51 to 7a1c05b Compare May 18, 2023 20:34
sjberman
sjberman requested changes May 19, 2023
View reviewed changes
cmd/gateway/commands.go Outdated Show resolved Hide resolved
cmd/gateway/commands_test.go Outdated Show resolved Hide resolved
cmd/gateway/main.go Outdated Show resolved Hide resolved
kate-osborn
kate-osborn requested changes May 19, 2023
View reviewed changes
cmd/gateway/main.go Outdated Show resolved Hide resolved
cmd/gateway/validation.go Outdated Show resolved Hide resolved
@pleshakov pleshakov requested review from kate-osborn and sjberman May 19, 2023 19:44
@pleshakov pleshakov requested a review from kate-osborn May 19, 2023 20:28
@pleshakov pleshakov merged commit dc046cc into nginxinc:main May 20, 2023
@pleshakov pleshakov deleted the feature/multiple-commands branch May 20, 2023 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

@sjberman sjberman sjberman approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pleshakov @sjberman @kate-osborn