switch from warning to debug when upstream labels are empty #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j1m-ryan
approved these changes
May 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
=====================================
Coverage 3.87% 3.87%
=====================================
Files 5 5
Lines 1316 1316
=====================================
Hits 51 51
Misses 1265 1265 ☔ View full report in Codecov by Sentry. |
jjngx
approved these changes
May 28, 2024
pdabelf5
force-pushed
the
upstream-labels-log
branch
from
da248e4 to
af8953b
Compare
pdabelf5
force-pushed
the
upstream-labels-log
branch
from
9b0ea5e to
b64d93e
Compare
vepatel
approved these changes
May 28, 2024
oseoin
approved these changes
May 28, 2024
pdabelf5
added a commit
that referenced
this pull request
May 29, 2024
pdabelf5
added a commit
that referenced
this pull request
May 29, 2024
pdabelf5
added
the
enhancement
This was referenced Jun 2, 2024
|
@pdabelf5 @oseoin @j1m-ryan this issue is still not resolved and we are getting level=debug ts=2024-06-17T07:28:09.172Z caller=nginx_plus.go:849 msg="wrong number of labels for upstream peer, empty labels will be used instead" upstream=tritonExternalSelfHosted-dev peer expected=1 got=0 can you please look into this at earliest since this is serious performance degradation for nginx-plus users . |
lucacome
added a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Turn down logging when upstream labels are empty.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
guide