Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yamllint action from reviewdog #136

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Use yamllint action from reviewdog #136

merged 1 commit into from
Jul 1, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Jul 1, 2024

Proposed changes

Replaces manual install of yamllint with an Action. This also adds annotations to the files.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING guide
  • I have proven my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have ensured the README is up to date
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

@lucacome lucacome self-assigned this Jul 1, 2024
@lucacome lucacome requested a review from a team as a code owner July 1, 2024 20:01
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jul 1, 2024
@lucacome lucacome merged commit a9bc049 into main Jul 1, 2024
14 checks passed
@lucacome lucacome deleted the chore/yamllint branch July 1, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacome @sjberman