Fix in combat signature #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick fix! |
ngld
pushed a commit
that referenced
this pull request
Jun 29, 2024
* Remove CombatantMemory61, CombatantMemory62 * Add cast target location for location-targetted abilities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous signature gave false "out of combat" signals when dying in combat.
Unfortunately, the line it uses is a
cmp byteline that doesn't end with the pointer,so SigScan needs to be updated to be able to handle getting rip addresses from
that style of line.
See corresponding quisquous/cactbot#4268 change.