Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Icon for Enter / configurable icons in HotkeysHelpComponent #65

Open
youseeus opened this issue Sep 20, 2022 · 2 comments
Open

Comments

@youseeus
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

The enter icon (⌤) in the HotkeysHelpComponent is not recognized by our users.

Expected behavior

It would be nice if the icon is changed if the Device is not a Apple-Device
or if we can configure the icon
or if it is replaced by just 'enter'

Minimal reproduction of the problem with instructions

open the HotkeysHelpComponent when a shortcut with 'enter' is added.

Environment


Angular version: 14.2.2

Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [x] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [x] Edge version XX

Others: 
 - [x] Windows
youseeus added a commit to youseeus/hotkeys that referenced this issue Sep 20, 2022
@youseeus
Copy link
Author

dbd3780

@NetanelBasal
Copy link
Member

You're welcome to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants