Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svg-generator): add ts-nocheck on generated files #140

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

shaharkazaz
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@stackblitz
Copy link

stackblitz bot commented Sep 20, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@shaharkazaz shaharkazaz merged commit bcceb6e into master Sep 20, 2023
2 checks passed
@shaharkazaz shaharkazaz deleted the generator-add-skip-ts-check branch September 20, 2023 09:08
@miki10194
Copy link

is it possible to avoid add this code? @shaharkazaz

@shaharkazaz
Copy link
Contributor Author

@miki10194 can you share why?

@miki10194
Copy link

miki10194 commented Dec 7, 2023

@shaharkazaz
Error:(1, 1) ESLint: Do not use "@ts-nocheck" because it alters compilation errors. (@typescript-eslint/ban-ts-comment) this problem during commit :) In this case I have to remove it manually

@shaharkazaz
Copy link
Contributor Author

@miki10194 Generally speaking I think you should exclude the generated files from linting as they are auto-generated.

The reason we've added this comment is to reduce redundant work as it's guaranteed that there are no semantic errors there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants