fix(Entity): Do not add Array.prototype properties to store (#782)

Closes #781
ngrx · Feb 9, 2018 · d537758 · d537758
1 parent ecf1ebf
commit d537758
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/modules/entity/spec/unsorted_state_adapter.spec.ts b/modules/entity/spec/unsorted_state_adapter.spec.ts
@@ -11,6 +11,20 @@ describe('Unsorted State Adapter', () => {
   let adapter: EntityStateAdapter<BookModel>;
   let state: EntityState<BookModel>;
 
+  beforeAll(() => {
+    Object.defineProperty(Array.prototype, 'unwantedField', {
+      enumerable: true,
+      configurable: true,
+      value: 'This should not appear anywhere',
+    });
+  });
+
+  afterAll(() => {
+    Object.defineProperty(Array.prototype, 'unwantedField', {
+      value: undefined,
+    });
+  });
+
   beforeEach(() => {
     adapter = createEntityAdapter({
       selectId: (book: BookModel) => book.id,

diff --git a/modules/entity/src/unsorted_state_adapter.ts b/modules/entity/src/unsorted_state_adapter.ts
@@ -25,9 +25,8 @@ export function createUnsortedStateAdapter<T>(selectId: IdSelector<T>): any {
   function addManyMutably(entities: any[], state: any): DidMutate {
     let didMutate = false;
 
-    for (let index in entities) {
-      didMutate =
-        addOneMutably(entities[index], state) !== DidMutate.None || didMutate;
+    for (const entity of entities) {
+      didMutate = addOneMutably(entity, state) !== DidMutate.None || didMutate;
     }
 
     return didMutate ? DidMutate.Both : DidMutate.None;