Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StoreModule) Fix typing to accept InjectionToken #375

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

Szpadel
Copy link
Contributor

@Szpadel Szpadel commented Sep 11, 2017

forFeature method accepts also InjectionToken as reducer, but this was disallowed by typescript definition.

forFeature method accepts also InjectionToken as reducer, but this was disallowed by typescript definition.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.243% when pulling 6382791 on Szpadel:patch-1 into 669b2f4 on ngrx:master.

@brandonroberts brandonroberts merged commit 38b2f95 into ngrx:master Sep 12, 2017
@brandonroberts
Copy link
Member

Thanks!

GulajavaMinistudio added a commit to TypescriptID/platform that referenced this pull request Sep 12, 2017
fix(Store): Fix typing for feature to accept InjectionToken (ngrx#375)
sharikovvladislav added a commit to sharikovvladislav/platform that referenced this pull request Sep 28, 2017
* 'master' of github.com:ngrx/platform: (35 commits)
  chore(Example): Add login info to example app. Fix sidenav issue with IE (ngrx#436)
  chore(docs): Fix OnRunEffects example (ngrx#430)
  chore(docs): Add docs on usage of custom router state serializer with store freeze (ngrx#426)
  chore(docs): Add missing from in metareducer example. (ngrx#418)
  docs(Entity): Fix examples for @ngrx/entity usage (ngrx#415)
  feat(Entity): Add default selectId function for EntityAdapter (ngrx#405)
  fix(Example): Add missing import for catch operator (ngrx#409)
  docs(effects): Remove usage of deprecated `toPayload` util in example (ngrx#407)
  chore(Example): Add Jest as test runner for example tests (ngrx#371)
  fix(Store): Refactor parameter initialization in combineReducers for Closure
  feat(Entity): Rename 'sort' to 'sortComparer'
  chore(docs): Minor fixes to entity interfaces documentation (ngrx#390)
  chore(docs): Change providing injected reducers by factory instead of value (ngrx#387)
  fix(Store): Fix typing for feature to accept InjectionToken (ngrx#375)
  chore(docs): Update @ngrx/entity documentation examples and usage (ngrx#369)
  docs(entity): Fix typo in url (ngrx#365)
  chore(Example): Documented @ngrx/entity and added to example app (ngrx#328)
  fix(RouterStore): Stringify error from navigation error event (ngrx#357)
  chore(docs): Fix action interface example (ngrx#360)
  chore(Example): Added ngrx-store-freeze meta-reducer to example application (ngrx#343)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants