Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(location): Renamed Location service to Router #56

Merged
merged 1 commit into from
Apr 12, 2016

Conversation

brandonroberts
Copy link
Member

BREAKING CHANGE: Renamed Location service to Router and renamed replaceState method to replace

Before:

import { Location } from '@ngrx/router';

class App {
    constructor(location: Location) {
        location.replaceState('/path', { query: 1 });
    }
}

After:

import { Router } from '@ngrx/router';

class App {
    constructor(router: Router) {
        router.replace('/path', { query: 1 });
    }
}

BREAKING CHANGE: Renamed `Location` service to `Router` and renamed `replaceState` method to `replace`

Before:
```ts
import { Location } from '@ngrx/router';

class App {
    constructor(location: Location) {
        location.replaceState('/path', { query: 1 });
    }
}
```

After:
```ts
import { Router } from '@ngrx/router';

class App {
    constructor(router: Router) {
        router.replace('/path', { query: 1 });
    }
}
```
@MikeRyanDev
Copy link
Member

LGTM

@MikeRyanDev MikeRyanDev merged commit 5b14ef9 into ngrx:master Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants