-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.3 #2388
Release 5.3 #2388
Conversation
Is it last 5.x release? Seems time for 6.0. How about including multitenancy support in 5.3 (#2108)? |
Of course having multi-tenancy would be great, but how far is it from being done? I consider the 5.3 has waited quite too long already. It is one year and a half after 5.2 initial release. I am not personally settled for going to 6.0 after 5.3. |
Well I consider it's ready :) |
I'm just a user of NHibernate but I'd like to voice support for including multitenancy in 5.3, it's a long awaited feature by many users and I'd personally rather wait a week / two than three months best case scenario for it. |
For me OData full support which was done thanks to all of you guys. That's what I am waiting for. 👍 Update: Also my friend is waiting for .NET Core full support. In 5.2.7 UWP applications are having compiling problems because of the old .Net framework dependencies (ConfigurationManager). |
We are one month later, and well, our overall contributing activity seems to me decreasing. The milestone has two PR which are waiting since long: #2365 and #2010. They both have conflicts with current master, @maca88. #2010 is validated by me, but has a pending review request asked to @bahusoid. #2365 was validated by me but has had some additional comments by @hazzik having incurred changes, without Alexander having acknowledge these changes for now. Bahusoid is also eager to have #2108 into 5.3, but Gunnar and me have expressed some concerns about how it works, and on my side I remain unconvinced. So I think other contributors should have a look and share their own thoughts. Should we go on waiting on these PR? |
@fredericDelaporte #2365 and #2010 are fine for me. Mainly were waiting for conflicts to be resovled. I don't have an opinion on #2108 (I never understood uber-monolithic applications where tenants could be switched at runtime) so would rely on others to approve. |
As a longtime user of NHibernate, I would like to vote to complete release 5.3 now. You guys have done a great job and fixed important bugs (e.g. NH-3865 in 2018) and features. Thanks a lot! |
Rebased and squashed. I intend to proceed with the release on next Sunday, if this PR is approved. |
It is about time to prepare this release I think.
Of course we may merge some more PR, but I think only a few more.