Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.3 #2388

Merged
merged 5 commits into from
Jul 19, 2020
Merged

Release 5.3 #2388

merged 5 commits into from
Jul 19, 2020

Conversation

fredericDelaporte
Copy link
Member

It is about time to prepare this release I think.

Of course we may merge some more PR, but I think only a few more.

@bahusoid
Copy link
Member

Is it last 5.x release? Seems time for 6.0.

How about including multitenancy support in 5.3 (#2108)?

@fredericDelaporte fredericDelaporte changed the title Release 5.3 WIP - Release 5.3 May 21, 2020
@fredericDelaporte fredericDelaporte changed the title WIP - Release 5.3 Release 5.3 May 21, 2020
@fredericDelaporte fredericDelaporte marked this pull request as draft May 21, 2020 18:58
@fredericDelaporte
Copy link
Member Author

Of course having multi-tenancy would be great, but how far is it from being done?

I consider the 5.3 has waited quite too long already. It is one year and a half after 5.2 initial release.
Many other things have been contributed into 5.3, and having to wait long for getting them released is not good for contributors engagement.

I am not personally settled for going to 6.0 after 5.3.
We could have a 5.4, with a shorter development time hopefully, like less than 6 months or even only 3 months. Why not after all?

@bahusoid
Copy link
Member

Of course having multi-tenancy would be great, but how far is it from being done?

Well I consider it's ready :)

@lofcz
Copy link
Contributor

lofcz commented May 25, 2020

I'm just a user of NHibernate but I'd like to voice support for including multitenancy in 5.3, it's a long awaited feature by many users and I'd personally rather wait a week / two than three months best case scenario for it.

@fairking
Copy link

fairking commented Jun 15, 2020

For me OData full support which was done thanks to all of you guys. That's what I am waiting for. 👍

Update: Also my friend is waiting for .NET Core full support. In 5.2.7 UWP applications are having compiling problems because of the old .Net framework dependencies (ConfigurationManager).

@fredericDelaporte
Copy link
Member Author

@fairking, about ConfigurationManager, is #2116 enough for your friend case to be fixed?

@fredericDelaporte
Copy link
Member Author

We are one month later, and well, our overall contributing activity seems to me decreasing.

The milestone has two PR which are waiting since long: #2365 and #2010. They both have conflicts with current master, @maca88. #2010 is validated by me, but has a pending review request asked to @bahusoid. #2365 was validated by me but has had some additional comments by @hazzik having incurred changes, without Alexander having acknowledge these changes for now.

Bahusoid is also eager to have #2108 into 5.3, but Gunnar and me have expressed some concerns about how it works, and on my side I remain unconvinced. So I think other contributors should have a look and share their own thoughts.

Should we go on waiting on these PR?

@hazzik
Copy link
Member

hazzik commented Jun 21, 2020

@fredericDelaporte #2365 and #2010 are fine for me. Mainly were waiting for conflicts to be resovled. I don't have an opinion on #2108 (I never understood uber-monolithic applications where tenants could be switched at runtime) so would rely on others to approve.

@ToGoOrNotToGo
Copy link

As a longtime user of NHibernate, I would like to vote to complete release 5.3 now. You guys have done a great job and fixed important bugs (e.g. NH-3865 in 2018) and features. Thanks a lot!

@fredericDelaporte
Copy link
Member Author

Rebased and squashed.
A few documentation PR remains in the milestone, but I think we can release without them: we could still merge them later and republish the documentation, without having to do a new release.

I intend to proceed with the release on next Sunday, if this PR is approved.

hazzik
hazzik previously approved these changes Jul 16, 2020
hazzik
hazzik previously approved these changes Jul 17, 2020
@fredericDelaporte fredericDelaporte merged commit cf32e05 into nhibernate:master Jul 19, 2020
@fredericDelaporte fredericDelaporte deleted the 5.3.0 branch July 19, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants