Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call BeforeAssemble on persistent collections' InitializeFromCache to allow batched cache fetching #3365

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Call BeforeAssemble on persistent collections' InitializeFromCache to allow batched cache fetching #3365

merged 1 commit into from
Jul 18, 2023

Conversation

hazzik
Copy link
Member

@hazzik hazzik commented Jul 17, 2023

Fixes #3359

@hazzik hazzik changed the base branch from master to 5.4.x July 17, 2023 15:47
@bahusoid
Copy link
Member

bahusoid commented Jul 17, 2023 •
edited
Loading

I probably OK with this fix though I think it's not fully correct.
Currently it calls ScheduleBatchLoadIfNeeded(object id, ISessionImplementor session, bool addToQueryCacheBatch)
with addToQueryCacheBatch set to true. But in this context query cache seems irrelevant so it should be false

@hazzik
Copy link
Member Author

hazzik commented Jul 17, 2023

I think it does not really matter. In this case the QueryCacheQueue will likely be null and so the parameter would be, pretty much, ignored.

@fredericDelaporte
Copy link
Member

Though, why 5.4? It does not look like a regression.

@hazzik
Copy link
Member Author

hazzik commented Jul 17, 2023

why 5.4? It does not look like a regression.

Yes, it is not regression, but a really nasty bug that renders collection cache unusable in some cases.

@hazzik hazzik changed the title Call BeforeAssemble on InitializeFromCache to allow batch fetching Call BeforeAssemble on persistent collections' InitializeFromCache to allow batch fetching Jul 17, 2023
@hazzik hazzik changed the title Call BeforeAssemble on persistent collections' InitializeFromCache to allow batch fetching Call BeforeAssemble on persistent collections' InitializeFromCache to allow batch cache fetching Jul 17, 2023
@hazzik hazzik changed the title Call BeforeAssemble on persistent collections' InitializeFromCache to allow batch cache fetching Call BeforeAssemble on persistent collections' InitializeFromCache to allow batched cache fetching Jul 17, 2023
@fredericDelaporte fredericDelaporte added this to the 5.4.4 milestone Jul 18, 2023
@fredericDelaporte
Copy link
Member

fredericDelaporte commented Jul 18, 2023 •
edited
Loading

Ok. (Well, it affects distributed caches, not in-memory caches.)

@hazzik hazzik enabled auto-merge (squash) July 18, 2023 08:10
@hazzik hazzik disabled auto-merge July 18, 2023 08:12
@hazzik hazzik removed the r: Fixed label Jul 18, 2023
@hazzik hazzik merged commit f3bd74e into nhibernate:5.4.x Jul 18, 2023
@hazzik hazzik deleted the gh-3359 branch July 18, 2023 12:30
@hazzik hazzik mentioned this pull request Jul 18, 2023
Closed
@bahusoid bahusoid mentioned this pull request Jul 24, 2023
Merged
bahusoid added a commit that referenced this pull request Jul 25, 2023
@bahusoid
Fix BeforeAssemble call for Map and IdentifierBag (#3380)
c9d0a95 
Fixup for #3365
@bahusoid bahusoid mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericDelaporte fredericDelaporte fredericDelaporte approved these changes

@bahusoid bahusoid Awaiting requested review from bahusoid

Assignees
No one assigned
Labels
r: Fixed t: Fix
Projects
None yet
Milestone
5.4.4
Development

Successfully merging this pull request may close these issues.

2nd level cache GetMany ineffective for collections
3 participants
@hazzik @bahusoid @fredericDelaporte