Enable Not node handling in HqlParser.NegateNode #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazzik
approved these changes
Aug 1, 2023
Comment on lines
+58
to
+64
| @"SELECT COUNT(ROOT.Id) | ||
| FROM Entity AS ROOT | ||
| WHERE NOT ( | ||
| NOT EXISTS (FROM ChildEntity AS CHILD WHERE CHILD.Parent = ROOT) | ||
| AND NOT ROOT.Name = 'Parent' | ||
| )").List(); | ||
| Assert.That(log.GetWholeLog(), Does.Not.Contains(" NOT ").IgnoreCase); |
There was a problem hiding this comment.
This test is about a more complex case than the comment in the parser: not (not a and not b) instead of not (not x). That is not a simple double not. Eliminating the not requires to change it to (a or b). Is it what is actually done?
There was a problem hiding this comment.
Eliminating the not requires to change it to (a or b). Is it what is actually done?
Yes. #3328 was actually about proper handling of and/or negation. And this test case just makes sure that we don't generate double not anymore.
There was a problem hiding this comment.
I have now locally checked. It does also add required parenthesis if needed, when the condition is more complex (like not (not a and not b) and c).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.