Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks and Segments should not have generic types #207

Closed
andrus opened this issue Oct 22, 2022 · 0 comments
Closed

Tasks and Segments should not have generic types #207

andrus opened this issue Oct 22, 2022 · 0 comments
Milestone

Comments

@andrus
Copy link
Contributor

andrus commented Oct 22, 2022

Tasks are used as generics-free LmTask instances, task builders do not have any API that can be assisted by generics.

Segments are used to process individual batches for a task internally store DataFrames, so they do not have a notion of generics type. There's nothing in the segment (other than declaration) that would define such a type.

So let's remove the generics parameter from tasks, task builders and segments.

Upgrade Notes

This affects listeners that accept segments as method parameters. There will be compilation errors, and the listeners must update their signatures, removing <T>.

@andrus andrus changed the title Segments should not have a generics type Tasks and Segments should not have a generics type Oct 22, 2022
@andrus andrus changed the title Tasks and Segments should not have a generics type Tasks and Segments should not have generics types Oct 22, 2022
@andrus andrus changed the title Tasks and Segments should not have generics types Tasks and Segments should not have generic types Oct 22, 2022
andrus added a commit that referenced this issue Oct 22, 2022
... cleaning up delete pipeline
andrus added a commit that referenced this issue Oct 22, 2022
... cleaning up create pipeline
andrus added a commit that referenced this issue Oct 22, 2022
... cleaning up create pipeline
andrus added a commit that referenced this issue Oct 22, 2022
... cleaning up create-or-update pipeline
andrus added a commit that referenced this issue Oct 22, 2022
... moving the generics boundary from DataObject to Persistent
for tasks. TODO: there's very little reason for the tasks to have a generics type
andrus added a commit that referenced this issue Oct 22, 2022
removing generic parameters from tasks
@andrus andrus added this to the 3.0.M1 milestone Oct 23, 2022
@andrus andrus closed this as completed Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant