refactor: remove handlebars #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
heenakwag
commented
Dec 5, 2019
•
heenakwag
commented
- apply tui-code-snippet@2
- apply template of tui-code-snippet
- docs, package.json, webpack ... will be modified after deploying tui-code-snippet@2.2.0 and tui-time-picker@2.0.3
- Test will be passed after applying latest of tui-code-snippet and tui-time-picker
jung-han
reviewed
Dec 6, 2019
jung-han
reviewed
Dec 6, 2019
jung-han
reviewed
Dec 6, 2019
jung-han
reviewed
Dec 6, 2019
jung-han
reviewed
Dec 6, 2019
seonim-ryu
reviewed
Dec 6, 2019
Comment on lines
+129
to
+132
| '<div class="tui-calendar">' | ||
| + ' <div class="tui-calendar-header"></div>' | ||
| + ' <div class="tui-calendar-body"></div>' | ||
| + '</div>'; |
There was a problem hiding this comment.
템플릿 리터럴을 사용할 수 있으면 참 좋겠지만..
이렇게 사용할 수도 있습니다ㅎ
this._container.innerHTM = [
'<div class="tui-calendar">',
'<div class="tui-calendar-header"></div>',
'<div class="tui-calendar-body"></div>',
'</div>'
].join('');
jung-han
reviewed
Dec 6, 2019
jung-han
reviewed
Dec 6, 2019
seonim-ryu
reviewed
Dec 6, 2019
seonim-ryu
reviewed
Dec 6, 2019
seonim-ryu
reviewed
Dec 6, 2019
seonim-ryu
approved these changes
Dec 6, 2019
heenakwag
force-pushed
the
refactor/remove-handlebars
branch
from
1dd3b1a to
0e3410a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.