Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add plugin interface (editorCore instance, keymap) #2647

Merged
merged 2 commits into from
Aug 5, 2022
Merged

feat: add plugin interface (editorCore instance, keymap) #2647

merged 2 commits into from
Aug 5, 2022

Conversation

jwlee1108
Copy link
Contributor

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jwlee1108 jwlee1108 requested a review from jajugoguma August 4, 2022 04:58
jajugoguma
jajugoguma approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@jajugoguma jajugoguma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료합니다!

@jwlee1108 jwlee1108 merged commit 3e33fd7 into master Aug 5, 2022
@jwlee1108 jwlee1108 deleted the feat/add-plugin-interfaces branch August 5, 2022 05:18
@jwlee1108 jwlee1108 mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jajugoguma jajugoguma jajugoguma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwlee1108 @jajugoguma