-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: link mark no longer building with misnamed getCustomAttrs (fix #2687, #2671, #2730) #2729
Conversation
There aren't tests that I saw which test the compiled output of the editor so it wasn't obvious to me how to write a unit test for this bug. |
Would love to get this merged ASAP. This is a pretty big issue for an application I'm working on |
I have the same issue. whenever I add a link into markdown editor it breaks wysiwyg mode. |
Is @jajugoguma the maintainer? |
@jajugoguma Merging this fix would be appreciated. Thank you |
I think @jwlee1108 is also a maintainer on this project? |
I've been busy with another project. I'll check it out as soon as I can. |
Awesome. Will there be a release setup soon? |
fix: link mark no longer building with misnamed getCustomAttrs (nhn#2729)
@jethrolarson It release with v3.2.1. if you use react or vue wrapper, you need to install v3.2.2 |
@jwlee1108 new release fixed everything for me 👍 |
Please check if the PR fulfills these requirements
fix #xxx[,#xxx]
, where "xxx" is the issue number)I'm not fully sure why but the cast or comment on the changed lines caused the bundler to compile the code wrong. I found this fix by accident by removing the unnecessary cast.