Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link mark no longer building with misnamed getCustomAttrs (fix #2687, #2671, #2730) #2729

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

jethrolarson
Copy link
Contributor

@jethrolarson jethrolarson commented Sep 12, 2022

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

I'm not fully sure why but the cast or comment on the changed lines caused the bundler to compile the code wrong. I found this fix by accident by removing the unnecessary cast.

@jethrolarson
Copy link
Contributor Author

There aren't tests that I saw which test the compiled output of the editor so it wasn't obvious to me how to write a unit test for this bug.

@jethrolarson jethrolarson changed the title fix: link mark no longer building with misnamed getCustomAttrs (fix #2687) fix: link mark no longer building with misnamed getCustomAttrs (fix #2687, #2671) Sep 12, 2022
@spencerpowell
Copy link

Would love to get this merged ASAP. This is a pretty big issue for an application I'm working on

@jethrolarson jethrolarson changed the title fix: link mark no longer building with misnamed getCustomAttrs (fix #2687, #2671) fix: link mark no longer building with misnamed getCustomAttrs (fix #2687, #2671, #2730) Sep 14, 2022
@benderillo
Copy link

I have the same issue. whenever I add a link into markdown editor it breaks wysiwyg mode.

@jethrolarson
Copy link
Contributor Author

Is @jajugoguma the maintainer?

@Recurse-blip
Copy link

@jajugoguma Merging this fix would be appreciated. Thank you

@IgorClouder
Copy link

Is @jajugoguma the maintainer?

I think @jwlee1108 is also a maintainer on this project?

@jwlee1108
Copy link
Contributor

I've been busy with another project. I'll check it out as soon as I can.

@jwlee1108 jwlee1108 merged commit d543b59 into nhn:master Sep 26, 2022
@jethrolarson
Copy link
Contributor Author

Awesome. Will there be a release setup soon?

ftassy added a commit to ftassy/tui.editor that referenced this pull request Sep 27, 2022
fix: link mark no longer building with misnamed getCustomAttrs (nhn#2729)
@jwlee1108
Copy link
Contributor

@jethrolarson It release with v3.2.1. if you use react or vue wrapper, you need to install v3.2.2
(I missed the editor version dependency on the wrapper package distribution.)

@luke-goddard
Copy link

@jwlee1108 new release fixed everything for me 👍

ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
)

Co-authored-by: Jethro Larson <jethro.larson@tableau.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants