fix: cannot edit after sort #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jajugoguma
commented
Dec 18, 2023
Comment on lines
+47
to
59
| data.rawData.forEach((rawRow, index) => { | ||
| const { rowKey } = rawRow; | ||
|
|
||
| if (isObservable(rawRow) || rowKeysInViewport.includes(rowKey)) { | ||
| makeObservable({ | ||
| store, | ||
| rowIndex: index, | ||
| silent: false, | ||
| lazyObservable: false, | ||
| forced: true, | ||
| }); | ||
| } | ||
| }); |
There was a problem hiding this comment.
rawRow가 반응형 데이터 일 때 대응하는 viewRow가 올바른 속성을 갖도록 하기 위해 이와 같이 수정했습니다.
정렬 후 기존에 반응형 데이터였던 데이터와 새롭게 뷰포트에 나타나는 데이터는 반응형 데이터야 합니다.
jajugoguma
commented
Dec 18, 2023
| const { data, column, id } = store; | ||
| const { rawData, viewData } = data; | ||
| const { treeColumnName } = column; | ||
| const rawRow = rawData[rowIndex]; | ||
|
|
||
| if (isObservable(rawRow)) { | ||
| if (!forced && isObservable(rawRow)) { |
There was a problem hiding this comment.
기존에 반응형 데이터 였던 row를 다시 반응형 데이터로 만들기 위해 forced 인자를 추가했습니다.
jwlee1108
approved these changes
Dec 19, 2023
넵 복합 기능 직접 하나씩 테스트해봤습니다! ㅎㅎㅎ |
sunyoungBae
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
fix #xxx[,#xxx], where "xxx" is the issue number)Description
Fixed an issue where editing could not be performed after sorting.
In the previous fix, i unobserved all data after sorting. However, i found additional issues where the next behavior did not work as intended (changing the data in the viewport to observable data).
Therefore, we discarded the previous fix and proceeded with a fix that proactively changes the rows that were previously observable data and the rows that are included in the viewport after sorting to observable data.
Thank you for your contribution to TOAST UI product. 🎉 😘 ✨