Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow custom styles. #17

Merged
merged 2 commits into from
Jan 21, 2017
Merged

feat: allow custom styles. #17

merged 2 commits into from
Jan 21, 2017

Conversation

gkatsev
Copy link
Contributor

@gkatsev gkatsev commented Jan 10, 2017

Uses jsdoc's staticFiles feature to copy the files over.
Then, the css property of templates is used to include these styles
in the layout.

For example:
With a folder structure like this:

static
└── styles
    └── custom.css

And a config like this:

{
  "templates": {
    "default": {
      "staticFiles": {
        "include": ["static/"]
      }
    },
    "css": ["styles/custom.css"]
}

styles/custom.css gets included in the layout.

Fixes #15.

@gkatsev gkatsev mentioned this pull request Jan 10, 2017
@gkatsev
Copy link
Contributor Author

gkatsev commented Jan 10, 2017

Also, I realized that if you add a fully qualified url to the css field, that works too.

@minkyu-yi
Copy link

minkyu-yi commented Jan 13, 2017

👍 Yeah, Good.
I really appreciate this development.

@minkyu-yi minkyu-yi added this to the 1.1.0 milestone Jan 13, 2017
@gkatsev
Copy link
Contributor Author

gkatsev commented Jan 13, 2017

I updated the README.

@minkyu-yi
Copy link

Could you rebase on develop?

@gkatsev gkatsev changed the base branch from master to develop January 20, 2017 19:26
Uses jsdoc's staticFiles feature to copy the files over.
Then, the `css` property of `templates` is used to include these styles
in the layout.

For example:
With a folder structure like this:
```
static
└── styles
    └── custom.css
```
And a config like this:
```js
{
  "templates": {
    "default": {
      "staticFiles": {
        "include": ["static/"]
      }
    },
    "css": ["styles/custom.css"]
}
```

`styles/custom.css` gets included in the layout.
@gkatsev
Copy link
Contributor Author

gkatsev commented Jan 20, 2017

Updated this PR to be against develop! Sorry for the wait.

@minkyu-yi
Copy link

Thank you~

@minkyu-yi minkyu-yi merged commit 05d8ff5 into nhn:develop Jan 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants