feat: migrate to aws-sdk-go-v2

[Bernix01]

Description

Hello :D

Problem

• AWS SDK automatically detects credentials besides static ones. Right now it is manually forcing static credentials.
• By default https is disabled which is required to be enabled under some circumstances (compliance)

Solution

• Bump AWS SDK to version 2
• Conditionally create config based on available parameters
• Add a new s3-disabble-https config variable

Notes

This change is meant to be retro-compatible and to not require changes on the end user.

[Ivanello]

thanks for resolving issue
waiting for merge

[dbarrosop]

I don't think this PR is correct. Did you test it?

[Bernix01]

Locally it doesn't throw compile errors and aws sdk documentation states that it will detect if not provided, maybe a new test case needs to be added for this?

[dbarrosop]

I don't think a test is necessarily needed but I don't think the go SDK works like this. So if you could test in your environment and let me know where you read in the go SDK documentation this is correct that'd be very helpful. Also, if you are going to use the environment to configure the AWS I think you should configure everything, including region and endpoint.

[Bernix01]

Some local evidence of POC (using AWS SSO)

[dbarrosop]

Ok, this looks more like what I expected, thanks a lot for the PR. I left a few minor comments, let me know when you address them so I can take a look again and do a few tests myself. You will also need to rebase the PR to fix the issue being raised by the CI (bumping go version due to a CVE).

[Bernix01]

It's ready @dbarrosop

[dbarrosop]

Good job, unfortunately, looks like tests aren't succeeding. I think you may have forgotten to update storage/s3_test.go.

[Bernix01]

now it should be good 👍

[dbarrosop]

Thanks, I will try to find time this week to do some thorough testing on a demo project

[Bernix01]

Hello, pinging to see if there's any news an about the testing on your end, this is an important feature for our company and we are looking forward for this to be released.

[dbarrosop]

Yes, unfortunately presigned URLs weren't working but I fixed that issue. If you give me permissions to push to your fork I can push my fix to your branch.

Let me know when it's done. Thanks.

[dbarrosop]

Thanks! Releasing v0.5.0 with this change.