Override nhsuk- brand prefix on notification banner and panel components
#1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrobertlloyd
force-pushed
the
govuk-components-brand
branch
from
0cfea19 to
65c7bf9
Compare
tvararu
force-pushed
the
govuk-components-brand
branch
from
65c7bf9 to
8bd01a0
Compare
|
Thanks @paulrobertlloyd! |
|
thomasleese
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trialing the change to
govuk-componentsproposed at x-govuk/govuk-components#552 (see x-govuk/govuk-components#547)This allows us to use
govuk-brand prefix for components that do not have associated styles innhsuk-frontend, and thus not need to extend thegovuk-prefixed classes to apply to components that have been forced to usenhsuk-prefix given the globalbrandsetting for this gem.There may be a corresponding update the GOV.UK Form Builder gem; that will allow us to review and remove styles for the password input and file upload form fields in a similar fashion.
Will merge once these upstream updates have been published. /cc @peteryates