Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flags to child records #2709

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Add flags to child records #2709

merged 5 commits into from
Dec 13, 2024

Conversation

thomasleese
Copy link
Contributor

This adds a number of flags to the component when viewing a "child record" allowing the nurses to see clearly if there are any flags on the patient.

Screenshots

Screenshot 2024-12-11 at 10 57 10
Screenshot 2024-12-11 at 10 57 39
Screenshot 2024-12-11 at 10 57 56

@thomasleese thomasleese marked this pull request as ready for review December 11, 2024 16:36
@paulrobertlloyd
Copy link
Contributor

paulrobertlloyd commented Dec 11, 2024 •
edited
Loading

Oooh, I didn't think to use the govuk warning component – I extended our custom status component (used for consent status currently), and created a bespoke icon (which is subtly different, matching the NHS design system’s rounded look for icons).

I may need take a look a closer look at this…

@thomasleese
Copy link
Contributor Author

Oooh, I didn't think to use the govuk warning component – I extended our custom status component (used for consent status currently), and created a bespoke icon (which is subtly different, matching the NHS design system’s rounded look for icons).

Ah, I was trying to find this in the prototype but couldn't figure it out, I'm happy with whatever approach to take, I think the main thing is to try and be consistent across the service and the prototype.

thomasleese and others added 5 commits December 13, 2024 14:52
@thomasleese
Add v1.2.0 feature flag
cfd4875 
This allows us to hide features for release 1.2.0 behind a feature flag
and only enable it once we're able to release it.
@thomasleese
Remove highlight from AppPatientSummaryComponent
951adf6 
This was only used in one place and it helps to keep this component
simpler by removing it, instead the caller can clear any changes and
that gives the caller more flexibility in terms of what changes get
highlighted.
@paulrobertlloyd @thomasleese
Add AppNoticeStatusComponent
4f9cc41
@thomasleese
Add AppPatientCardComponent
c08f136 
This encapsulates the logic related to render a "Child record" card
which is shown in a number of different places.
@thomasleese
Add flags to AppPatientCardComponent
8bbdc2a 
This adds a number of flags to the component when viewing a "child
record" allowing the nurses to see clearly if there are any flags on the
patient.
@tvararu tvararu temporarily deployed to mavis-pr-2709 December 13, 2024 14:52 Inactive
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tvararu tvararu merged commit ef18b6b into main Dec 13, 2024
13 checks passed
@tvararu tvararu deleted the child-record-flag branch December 13, 2024 15:00
@tvararu tvararu added this to the v1.1.1 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvararu tvararu tvararu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasleese @paulrobertlloyd @tvararu