Mark JavaScript tests with :js
#2751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that Capybara automatically uses the `javascript_driver` and we don't need to mark the test as a system test. This avoids the need to use `driven_by` and mark the test as a `:system` test while being in the directory for feature tests. In the future we might want to switch all these tests over to be `:system` tests, as this is the standard Rails approach now, but for now we can leave it like this.
|
benilovj
approved these changes
Dec 16, 2024
tvararu
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that Capybara automatically uses the
javascript_driverand we don't need to mark the test as a system test. This avoids the need to usedriven_byand mark the test as a:systemtest while being in the directory for feature tests.In the future we might want to switch all these tests over to be
:systemtests, as this is the standard Rails approach now, but for now we can leave it like this.