Disable :js tests if Chrome is unavailable
#2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvararu
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
We've only got one test that requires JavaScript so I thought this would be a simpler approach for now, if we add more then we might want to consider adding a Selenium WebDriver for Firefox or Safari as an alternative.
Rather use PlayWright if testing Firefox/Safari is ever a need 👍
We use Google Chrome (via Cuprite) to run feature tests with client-side JavaScript. This updates the `spec_helper` to first detect whether Chrome is available, and if not, disable `:js` tests. This is because not all developers will have Chrome available on their machine. We've only got one test that requires JavaScript so I thought this would be a simpler approach for now, if we add more then we might want to consider adding a Selenium WebDriver for Firefox or Safari as an alternative.
thomasleese
force-pushed
the
run-tests-without-chrome
branch
from
1f9f9b4 to
db37666
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use Google Chrome (via Cuprite) to run feature tests with client-side JavaScript. This updates the
spec_helperto first detect whether Chrome is available, and if not, disable:jstests. This is because not all developers will have Chrome available on their machine.We've only got one test that requires JavaScript so I thought this would be a simpler approach for now, if we add more then we might want to consider adding a Selenium WebDriver for Firefox or Safari as an alternative.