Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent consecutive statuses appearing inline #2776

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

paulrobertlloyd
Copy link
Contributor

@paulrobertlloyd paulrobertlloyd commented Dec 18, 2024

Using inline-flex for .app-status means several consecutive status items can appear inline, when they should appear stacked. Using inline-flex also adds unwanted spacing when this component appears in a table cell, which upcoming design changes may require.

Before

Inline flow

After

Block flow

@tvararu tvararu temporarily deployed to mavis-pr-2776 December 18, 2024 11:26 Inactive
@tvararu tvararu added the 🐞 bug Something isn't working label Dec 18, 2024
@tvararu tvararu added this to the v1.1.2 milestone Dec 18, 2024
@paulrobertlloyd paulrobertlloyd changed the title Use block flex for app status component to prevent consecutive statuses appearing inline Prevent consecutive statuses appearing inline Dec 18, 2024
@tvararu tvararu modified the milestones: v1.1.2, v1.1.1 Dec 18, 2024
@tvararu tvararu merged commit edd43dd into main Dec 18, 2024
13 checks passed
@tvararu tvararu deleted the app-status-flex branch December 18, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants