Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors when session data defaults crashes #402

Merged
merged 3 commits into from
Nov 12, 2024
+3 −1
Merged

Log errors when session data defaults crashes #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc78eab
Log errors when session data defaults crashs
edwardhorsford Nov 12, 2024
50d73da
Update changelog
edwardhorsford Nov 12, 2024
de247ee
Rename 'e' to 'error' for clarity
edwardhorsford Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

- Remove guidance and tutorials - these can now be found online on the [NHS Prototype Kit website](https://prototype-kit.service-manual.nhs.uk) - ([PR 385](https://github.com/nhsuk/nhsuk-prototype-kit/pull/385))
- Update NHS frontend to 9.1.0
- Show errors when session data defaults crashes ([PR 402](https://github.com/nhsuk/nhsuk-prototype-kit/pull/402))

## 5.0.0 - 15 October 2024

Expand Down
3 changes: 2 additions & 1 deletion lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,9 @@ const sessionDataDefaultsFile = path.join(__dirname, '../app/data/session-data-d
try {
/* eslint-disable-next-line */
sessionDataDefaults = require(sessionDataDefaultsFile);
} catch (e) {
} catch (error) {
console.error('Could not load the session data defaults from app/data/session-data-defaults.js. Might be a syntax error?'); // eslint-disable-line no-console
console.error(error)
}

// Middleware - store any data sent in session, and pass it to all views
Expand Down