Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design example 'Open in new window' link #548

Closed
davidhunter08 opened this issue Feb 6, 2020 · 1 comment
Closed

Design example 'Open in new window' link #548

davidhunter08 opened this issue Feb 6, 2020 · 1 comment
Labels
accessibility Accessibility related

Comments

@davidhunter08
Copy link
Contributor

davidhunter08 commented Feb 6, 2020 •
edited
Loading

What

On the design examples, the link 'Open in new window' gives no context of what you are opening in a new window.

Screenshot 2020-02-06 at 11 06 45

Why

It's an accessibility issue, especially when there is more than one design example on the page.

Fix

Add visually hidden text to the the link.

For example: 'Open this [style, component or pattern name] example in a new window'.
@davidhunter08 davidhunter08 added the accessibility Accessibility related label Feb 6, 2020
davidhunter08 added a commit that referenced this issue Feb 6, 2020
@davidhunter08
[refs #548] Update design example new window link
6675818 
- update style
- add 'this' text to the link
davidhunter08 added a commit that referenced this issue Feb 6, 2020
@davidhunter08
[refs #548] Update link style
f244828
davidhunter08 added a commit that referenced this issue Feb 6, 2020
@davidhunter08
[refs #548] Update design example link hover styles
0acb76e
chrimesdev pushed a commit that referenced this issue Feb 7, 2020
@davidhunter08
[refs #548] Update design example new window link
398bbef 
* [refs #548] Update design example new window link
* [refs #548] add 'this' text to the link
* [refs #548] Update link style
* [refs #548] Update design example link hover styles
davidhunter08 added a commit that referenced this issue Feb 7, 2020
@davidhunter08
[refs #548] Increase design example new window link size
65f7afa
@chrimesdev
Copy link
Member

This was released in v3.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Accessibility related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrimesdev @davidhunter08