Brad's feedback.

ni · Aug 30, 2024 · f3f9e1e · f3f9e1e
1 parent 479f855
commit f3f9e1e
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/src/grpc_client.cc b/src/grpc_client.cc
@@ -25,11 +25,6 @@ namespace grpc_labview
 
     //---------------------------------------------------------------------
     //---------------------------------------------------------------------
-    static bool ichar_equals(char a, char b)
-    {
-        return std::tolower(static_cast<unsigned char>(a)) == std::tolower(static_cast<unsigned char>(b));
-    }
-
     static bool IsLoopbackAddress(const char* address)
     {
         std::string hostname(address);
@@ -50,16 +45,15 @@ namespace grpc_labview
             }
         }
 
-        std::string localhost("localhost");
-        bool isLoopback = hostname.size() == localhost.size() && std::equal(hostname.begin(), hostname.end(), localhost.begin(), ichar_equals);
+        bool isLoopback = hostname == "localhost" || hostname == "LOCALHOST";
         if (!isLoopback)
         {
             try
             {
                 asio::ip::address ip_address = asio::ip::make_address(hostname);
                 isLoopback = ip_address.is_loopback();
             }
-            catch (std::exception)
+            catch (std::exception&)
             {
                 isLoopback = false;
             }