-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cmake tests that prevents people from changing message datatypes #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yash-ni
commented
Jan 9, 2024
•
edited
Loading
edited
- Added a new python script that uses pytest to check whether any message metadata structure has been changed or not.
- Added another script that checks for changes in exported function signatures as well.
- Created a new custom target in cmakelists to run the tests and made it a dependency for server and generator dll build process.
- Updated github workflows to run the tests.
ni-sujain
reviewed
Jan 17, 2024
ni-sujain
reviewed
Jan 17, 2024
ni-sujain
reviewed
Jan 17, 2024
ni-sujain
reviewed
Jan 17, 2024
ni-sujain
reviewed
Jan 17, 2024
ni-sujain
reviewed
Jan 17, 2024
ni-sujain
reviewed
Jan 17, 2024
ni-sujain
reviewed
Jan 17, 2024
ni-sujain
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do some testing on getexported functions and then submit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.