Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed gRPC Client Hang issue #349

Merged
merged 18 commits into from
Mar 5, 2024
Merged

Fixed gRPC Client Hang issue #349

merged 18 commits into from
Mar 5, 2024

Conversation

yash-ni
Copy link
Collaborator

@yash-ni yash-ni commented Feb 26, 2024 •
edited
Loading

Fix for #345 #330 #324 #320

Changes:

  1. Fixed the race condition issue with occurrence hence solving a lot of client hang bugs
  2. Added feature toggle for running the client without LabVIEW Occurrence.
  3. Changed ActiveClientCalls from std::list to std::unordered_map hence resulting in a little performance increase.

@yash-ni yash-ni merged commit 9b486f5 into ni:master Mar 5, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ni-sujain ni-sujain ni-sujain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yash-ni @ni-sujain