-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid proxy issues for localhost only communication #377
Avoid proxy issues for localhost only communication #377
Conversation
… can't get added to the typedef and break it.
…es instead of files when browsing.
Could the user just specify a local env variable to specify if the proxy should be ignored for localhost etc? |
Yes, that is an option and is what we have been telling customers to avoid these issues. However, the errors you get when this is a problem aren't very helpful, and a lot of time is wasted via support channels before getting to the bottom of what is wrong. |
@yash-ni @ni-sujain It looks like you have the most recently submitted PRs to the repo. Can you help me find someone to review this PR and/or give me write access to the repo so I can see who approving reviewers are? |
I have given you access. Thanks |
Description
This PR attempts to avoid grpc connection issues due to http proxies when communicating over loopback addresses. If we detect the target address for a gRPC channel is the localhost or equivalent, then we explicitly disable sending traffic through the proxy.
Implementation
asio
LabVIEWgRPCClient::Connect
to setGRPC_ARG_ENABLE_HTTP_PROXY
to false if the target address is detected to be a loopback address.Testing
I didn't see much in the way of an automated regression test framework so I didn't create any automated tests as part of this change. I manually tested that the following addresses worked and used the expected proxy settings: