-
Notifications
You must be signed in to change notification settings - Fork 13
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Task2402796] Automatically Create Enum Annotations Based on Controls (…
…#215) * Fixed issue with typing referencing old Type Specialization enum. * Initial changes for autocreate enums annotations based on enum controls in the panel * Minor cleanup * Added Get Results Metadata that mirrors Get Configuration Metadata and updated Get MetaData from Results to call it. * Added Get Results Metadata.vi to lvlib * Fixed issue with parameter name. * Created two new subVIs to split logic out * Refactored Create Enum Type Specialization to work with both Enums and Arrays of Enums. * Closed reference * Updated Get Configuration Metadata.vi and Get Results Metadata.vi to call new subVIs. Also resolved some PR comments. * Updated callers of Get Results MetaData.vi and Get Configuration MetaData.vi * Updated lvlib to include new helpers. * Cleaned up panels. * Added IsArrayControl and IsEnumControl helpers * Added IsEnumOrEnumArrayControl helper * Updated Filter for Enum Controls to use new helpers. * Made Create Enum Type Specialization private. Update lvlib * Removed parameter name parameter and moved that logic internal to Create Enum Type Specialization. * Fixed up callers for removal of parameter name parameter * Fixed issue where we create enum.values even if no enums. * Refactored helper to check if is enum array rather than any array * Minor cleanup * Removed validationand generic up-casting code and updated to use helper VIs. * Added another helper VI to share more code between Get Configuration Metadata and Get Results Metadata. * Made another helper to consolidate logic between Get Configuration Metadata and Get Results Metadata. * Fixed icon art * Fixed up lvlib * Updated IEnumArrayControl to use IsEnumControl. * Fixed an issue where Get Results Metadata uses Measurement Configuration CTL Path rather than Measurement Results CTL Path. * Refactored IsEnumControl.vi and IsEnumArrayControl.vi to output casted references. Updated Filter for Enum Controls.vi to extract enum references. Updated Create Enum Type Specialization.vi to only take enum references as input. * Updated LabVIEW datatype to Measurement datatype.vi to convert enum types to enum rather than coerced to UInt * Fixed an issue where we did not update supported tag. * Added Get Annotations For Parameter helper * Refactored to remove Get Results Metadata and Get Configuration Metadata subVIs as they really only differed in the path. Now Get MetaData from Results and Get MetaData from Configuration both call into the generic Get Metadata.vi * Fixed up lvlib * Removed unused items in unbundle * Renamed Parameter_AnnotationsEntry.ctl for use in both configuration and output. * Updated lvlib * Renamed Output to OutputParameter. Switched to using Parameter_AnnotationsEntry.ctl rather than the v2. * Updated references for Parameter_AnnotationsEntry.ctl. * Updated callers of OutputParameter.ctl * I have no idea why LabView autodirties and wants to resave this file again every time I open the project. I'll trust labview and take it's change.
- Loading branch information
1 parent
40fc273
commit 6fdd748
Showing
21 changed files
with
10 additions
and
4 deletions.
There are no files selected for viewing
Binary file modified
BIN
-44 Bytes
(100%)
...ementLink Measurement Server/Classes/MeasurementPluginService/Get Type Specializations.vi
Binary file not shown.
Binary file modified
BIN
+1.38 KB
(100%)
Source/Runtime/MeasurementLink Measurement Server/Helpers/Create Enum Type Specialization.vi
Binary file not shown.
Binary file added
BIN
+15.8 KB
Source/Runtime/MeasurementLink Measurement Server/Helpers/Filter for Enum Controls.vi
Binary file not shown.
Binary file added
BIN
+14.5 KB
Source/Runtime/MeasurementLink Measurement Server/Helpers/Get Annotations For Parameter.vi
Binary file not shown.
Binary file removed
BIN
-25.4 KB
Source/Runtime/MeasurementLink Measurement Server/Helpers/Get Configuration Metadata.vi
Binary file not shown.
Binary file added
BIN
+19.5 KB
Source/Runtime/MeasurementLink Measurement Server/Helpers/Get Enum Type Specializations.vi
Binary file not shown.
Binary file added
BIN
+17.5 KB
...time/MeasurementLink Measurement Server/Helpers/Get Measurement Configuration Controls.vi
Binary file not shown.
Binary file modified
BIN
-548 Bytes
(98%)
...ce/Runtime/MeasurementLink Measurement Server/Helpers/Get MetaData from Configurations.vi
Binary file not shown.
Binary file modified
BIN
-2.8 KB
(90%)
Source/Runtime/MeasurementLink Measurement Server/Helpers/Get MetaData from Results.vi
Binary file not shown.
Binary file added
BIN
+18.8 KB
Source/Runtime/MeasurementLink Measurement Server/Helpers/Get Metadata.vi
Binary file not shown.
Binary file added
BIN
+15 KB
Source/Runtime/MeasurementLink Measurement Server/Helpers/IsEnumArrayControl.vi
Binary file not shown.
Binary file added
BIN
+14 KB
Source/Runtime/MeasurementLink Measurement Server/Helpers/IsEnumControl.vi
Binary file not shown.
Binary file modified
BIN
-304 Bytes
(99%)
...me/MeasurementLink Measurement Server/Helpers/LabVIEW datatype to Measurement datatype.vi
Binary file not shown.
Binary file modified
BIN
+28 Bytes
(100%)
...ce/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/ConfigurationParameter.ctl
Binary file not shown.
Binary file removed
BIN
-5.11 KB
...ementLink Measurement Server/Helpers/TypeDefs/ConfigurationParameter_AnnotationsEntry.ctl
Binary file not shown.
Binary file modified
BIN
-700 Bytes
(95%)
Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/GetMetadataResponse.ctl
Binary file not shown.
Binary file modified
BIN
-720 Bytes
(94%)
Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/MeasurementSignature.ctl
Binary file not shown.
Binary file removed
BIN
-7.5 KB
Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/Output.ctl
Binary file not shown.
Binary file added
BIN
+7.09 KB
Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/OutputParameter.ctl
Binary file not shown.
Binary file added
BIN
+5.11 KB
...untime/MeasurementLink Measurement Server/Helpers/TypeDefs/Parameter_AnnotationsEntry.ctl
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters