-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced spawningpool with measlinkbot self-hosted runner #456
Conversation
Currently, addressing few issues:
These two issues has to be resolved from runner side. Hence, no changes for these issues needed in this PR. |
0 of 0 files processed successfully. |
0 of 0 files processed successfully. |
Test analysis till now:
|
0 of 0 files processed successfully. |
0 of 0 files processed successfully. |
0 of 0 files processed successfully. |
0 of 0 files processed successfully. |
0 of 0 files processed successfully. |
0 of 0 files processed successfully. |
1 of 2 files processed successfully. Processed Possible reason(s): LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.Command requires GPIB Controller to be Controller-In-Charge. Complete call chain: |
Source/Tests/run_tests.vi
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff Image Data for Source/Tests/run_tests.vi as follows
No images produced. This is indicative of no functional changes, e.g. resaved, mass-compiled, or cosmetic changes only.
1 of 2 files processed successfully. Processed Possible reason(s): LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.Command requires GPIB Controller to be Controller-In-Charge. Complete call chain: |
Source/Tests/run_tests.vi
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff Image Data for Source/Tests/run_tests.vi as follows
No images produced. This is indicative of no functional changes, e.g. resaved, mass-compiled, or cosmetic changes only.
1 of 2 files processed successfully. Processed Possible reason(s): LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.Command requires GPIB Controller to be Controller-In-Charge. Complete call chain: |
Source/Tests/run_tests.vi
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff Image Data for Source/Tests/run_tests.vi as follows
No images produced. This is indicative of no functional changes, e.g. resaved, mass-compiled, or cosmetic changes only.
1 of 2 files processed successfully. Processed Possible reason(s): LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.Command requires GPIB Controller to be Controller-In-Charge. Complete call chain: |
Source/Tests/run_tests.vi
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff Image Data for Source/Tests/run_tests.vi as follows
No images produced. This is indicative of no functional changes, e.g. resaved, mass-compiled, or cosmetic changes only.
1 of 2 files processed successfully. Processed Possible reason(s): LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.Command requires GPIB Controller to be Controller-In-Charge. Complete call chain: |
Source/Tests/run_tests.vi
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff Image Data for Source/Tests/run_tests.vi as follows
No images produced. This is indicative of no functional changes, e.g. resaved, mass-compiled, or cosmetic changes only.
1 of 2 files processed successfully. Processed Possible reason(s): LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.Command requires GPIB Controller to be Controller-In-Charge. Complete call chain: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff Image Data for Source/Tests/run_tests.vi as follows
No images produced. This is indicative of no functional changes, e.g. resaved, mass-compiled, or cosmetic changes only.
1 of 2 files processed successfully. Processed Possible reason(s): LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.Command requires GPIB Controller to be Controller-In-Charge. Complete call chain: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff Image Data for Source/Tests/run_tests.vi as follows
No images produced. This is indicative of no functional changes, e.g. resaved, mass-compiled, or cosmetic changes only.
1 of 2 files processed successfully. Processed Possible reason(s): LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.Command requires GPIB Controller to be Controller-In-Charge. Complete call chain: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff Image Data for Source/Tests/run_tests.vi as follows
No images produced. This is indicative of no functional changes, e.g. resaved, mass-compiled, or cosmetic changes only.
@bkeryan, @dixonjoel, @jasonmreding , @aepete, @vigkre |
What does this Pull Request accomplish?
This PR replaces spawningpool with measlinkbot as the self-hosted runner which runs on four LV versions (2020, 2021, 2022, 2023).
Run G tests workflow:
filename too long
error.Run VI analyzer workflow:
filename too long
error.run_vi_analyzer.py
to acceptlabview-path
andport-number
arguments.Run PR Commenter workflow:
filename too long
error.run_diff.py
to run in only LV 2020 version.Why should this Pull Request be merged?
Implements Technical Debt 2350468: Redundant / externally-maintained test runners.
What testing has been done?
Running the workflow Run G Tests, Run VI Analyzer, Run PR Commenter workflows.
Known issue in measlinkbot: Bug 2581216: measlinkbot is not reliable enough, this means sometimes measlinkbot is inconsistent and leaves the jobs unpicked. A small workaround would be to cancel and re run the workflow again. Once the bug is fixed, this issue will be resolved.