Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MeasurementLink top-level package and an examples package. #493

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Add MeasurementLink top-level package and an examples package. #493

merged 7 commits into from
Apr 30, 2024

Conversation

sreekantham
Copy link
Contributor

@sreekantham sreekantham commented Mar 8, 2024 •
edited
Loading

  • This contribution adheres to CONTRIBUTING.md. (Required)
  • Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

Adds a MeasurementLink top-level package. Adds an examples package. Cleans up license info and icons in all packages.

Updated minimum LabVIEW version to 2021 per internal decision document (https://dev.azure.com/ni/Decision%20Registers/_workitems/edit/2721249)

Please note: The new packages only work when built with LV 2021 from VIPM. It doesn't work when using LV 2020 because our drivers don't install LV 2020 support, thus the examples are broken. Further it doesn't work with LV 2023 (and perhaps 2022 as well) because the VI's moved to their version agnostic location. We would need to resave our examples in the given version when the time comes. CC @cfuentes-ni

Why should this Pull Request be merged?

Easy single package to install MeasurementLink.

What testing has been done?

Manually tested with LV 2021 and 2023.

dixonjoel
dixonjoel approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@dixonjoel dixonjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @jasonmreding has already given this one a thorough review. So approving pending his approval.

Source/Build Specs/MeasurementLink Generator.vipb Outdated Show resolved Hide resolved
aepete
aepete approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@aepete aepete left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide brief rationale for having updated the Package_LabVIEW_Version to 2021 in the vipb files?

edit: No response needed.... The answer had already been provided within the updated PR description.

@sreekantham sreekantham merged commit 0c2ca19 into main Apr 30, 2024
6 checks passed
@sreekantham sreekantham deleted the users/ksreekan/update-package branch April 30, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmreding jasonmreding jasonmreding approved these changes

@aepete aepete aepete approved these changes

@cfuentes-ni cfuentes-ni cfuentes-ni approved these changes

@dixonjoel dixonjoel dixonjoel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sreekantham @dixonjoel @cfuentes-ni @aepete @jasonmreding