Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: Update NI-Scope to demonstrate PinGroup usage #495

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

Avinash2Suresh
Copy link
Contributor

  • This contribution adheres to CONTRIBUTING.md. (Required)
  • Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

  • Update the NI-Scope example to reserve the session using a pin group by grouping existing pins.

Why should this Pull Request be merged?

To demonstrate obtaining connections at both the individual pin and pin group levels when reserving the session using a pin group:

  • Obtain connections using individual pins.
  • Obtain connections using pin groups.

What testing has been done?

  • Manually ran the measurement and verified it from both InstrumentStudio and TestStand.

Copy link

3 of 3 files processed successfully.
Processed Measurement Configuration.ctl: Success
Diff images generated for Source/Example Measurements/NI-SCOPE Acquire Waveform/NI-SCOPE Acquire Waveform/Measurement Configuration.ctl.
Attribute Changes
     None

Processed Measurement Logic.vi: Success
Diff images generated for Source/Example Measurements/NI-SCOPE Acquire Waveform/NI-SCOPE Acquire Waveform/Measurement Logic.vi.
Attribute Changes
     None

Processed Measurement UI.vi: Success
Diff images generated for Source/Example Measurements/NI-SCOPE Acquire Waveform/NI-SCOPE Acquire Waveform/Measurement UI.vi.
Attribute Changes
     None

Copy link

3 of 3 files processed successfully.
Processed Measurement Configuration.ctl: Success
Diff images generated for Source/Example Measurements/NI-SCOPE Acquire Waveform/NI-SCOPE Acquire Waveform/Measurement Configuration.ctl.
Attribute Changes
     None

Processed Measurement Logic.vi: Success
Diff images generated for Source/Example Measurements/NI-SCOPE Acquire Waveform/NI-SCOPE Acquire Waveform/Measurement Logic.vi.
Attribute Changes
     None

Processed Measurement UI.vi: Success
Diff images generated for Source/Example Measurements/NI-SCOPE Acquire Waveform/NI-SCOPE Acquire Waveform/Measurement UI.vi.
Attribute Changes
     None

@Avinash2Suresh
Copy link
Contributor Author

I've created the ni_measurementlink_generator and ni_measurementlink_service locally and validated the example. I'll keep the PR open until we have the pre-release ready (Joel will assist in creating it) and can test the changes with the latest packages. Kindly consider reviewing the changes.

@Avinash2Suresh
Copy link
Contributor Author

@dixonjoel I've validated this example with the latest pre-release and it's working fine in both InstrumentStudio and TestStand. Hence, I'm merging this PR and we're good to add this example in the pre-release.

@Avinash2Suresh Avinash2Suresh merged commit 22c4078 into main Mar 12, 2024
3 checks passed
@Avinash2Suresh Avinash2Suresh deleted the users/avinash/update-niscope-example branch March 12, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants