Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service to include I/O resource specialization in preference to Pin #507

Merged
merged 8 commits into from
Apr 18, 2024
Merged

Update service to include I/O resource specialization in preference to Pin #507

merged 8 commits into from
Apr 18, 2024

Conversation

jonathanmendez
Copy link
Contributor

@jonathanmendez jonathanmendez commented Apr 17, 2024 •
edited by ni-vsts-admins
Loading

  • This contribution adheres to CONTRIBUTING.md. (Required)
  • Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

  • Add a new ioresource type specialization and associated ioresource.instrument_type annotation.
  • Update comments in Get Type Specialization.vi to point to using ioresource instead of pin for pins or channels.
  • Update examples to use ioresource type specialization.

Why should this Pull Request be merged?

AB#2666680
This updates the LabVIEW measurement service libraries to better indicate support for both pins and channels.

What testing has been done?

Manually installed the changed files to vi.lib and ran the modified DCPower example successfully.

@jonathanmendez
Add ioresource and ioresource/instrument_type to specialization enums
13c7d9f 
Signed-off-by: Jonathan Mendez <jonathan.mendez@ni.com>
@jonathanmendez
Update comment in Get Type Specializations.vi to indicate using iores…
0d99f1c 
…ource

Signed-off-by: Jonathan Mendez <jonathan.mendez@ni.com>
@jonathanmendez
Update strict vi reference connpane to match new enum values
83a0a22 
Signed-off-by: Jonathan Mendez <jonathan.mendez@ni.com>
@jonathanmendez jonathanmendez changed the title Users/jomendez/use ioresource specialization Update service to include I/O resource specialization in preference to Pin Apr 17, 2024
@github-actions GitHub Actions
Copy link

12 of 12 files processed successfully.
Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/Game Of Life/Game Of Life/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/Keysight 34401A DMM Measurement/Keysight 34401A DMM Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-DCPower Source DC Voltage/NI-DCPower Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-DMM Measurement/NIDmmMeasurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-Digital SPI/NI-Digital Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-FGEN Standard Function/NIFgenStandardFunction/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-SCOPE Acquire Waveform/NI-SCOPE Acquire Waveform/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/VISA Measurement/VISA Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Generator/MeasurementLink Measurement Template/Get Type Specializations.vi.
Attribute Changes
     None

Processed Type Specialization Key.ctl: Success
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/Type Specialization Key.ctl.
Attribute Changes
     VI Icon (B/W)

Processed Type Specialization.ctl: Success
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/Type Specialization.ctl.
Attribute Changes
     VI Icon (B/W)

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Measurement Plugin Service/Get Type Specializations.vi.
Attribute Changes
     VI icon

@jonathanmendez
Fix sizes of metadata constants
e0913f7 
Signed-off-by: Jonathan Mendez <jonathan.mendez@ni.com>
@github-actions GitHub Actions
Copy link

12 of 12 files processed successfully.
Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/Game Of Life/Game Of Life/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/Keysight 34401A DMM Measurement/Keysight 34401A DMM Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-DCPower Source DC Voltage/NI-DCPower Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-DMM Measurement/NIDmmMeasurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-Digital SPI/NI-Digital Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-FGEN Standard Function/NIFgenStandardFunction/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-SCOPE Acquire Waveform/NI-SCOPE Acquire Waveform/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/VISA Measurement/VISA Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Generator/MeasurementLink Measurement Template/Get Type Specializations.vi.
Attribute Changes
     None

Processed Type Specialization Key.ctl: Success
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/Type Specialization Key.ctl.
Attribute Changes
     VI Icon (B/W)

Processed Type Specialization.ctl: Success
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/Type Specialization.ctl.
Attribute Changes
     VI Icon (B/W)

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Measurement Plugin Service/Get Type Specializations.vi.
Attribute Changes
     VI icon

@github-actions GitHub Actions
Copy link

12 of 12 files processed successfully.
Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/Game Of Life/Game Of Life/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/Keysight 34401A DMM Measurement/Keysight 34401A DMM Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-DCPower Source DC Voltage/NI-DCPower Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-DMM Measurement/NIDmmMeasurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-Digital SPI/NI-Digital Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-FGEN Standard Function/NIFgenStandardFunction/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/NI-SCOPE Acquire Waveform/NI-SCOPE Acquire Waveform/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Example Measurements/VISA Measurement/VISA Measurement/Get Type Specializations.vi.
Attribute Changes
     None

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Generator/MeasurementLink Measurement Template/Get Type Specializations.vi.
Attribute Changes
     None

Processed Type Specialization Key.ctl: Success
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/Type Specialization Key.ctl.
Attribute Changes
     VI Icon (B/W)

Processed Type Specialization.ctl: Success
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Helpers/TypeDefs/Type Specialization.ctl.
Attribute Changes
     VI Icon (B/W)

Processed Get Type Specializations.vi: Success
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Measurement Plugin Service/Get Type Specializations.vi.
Attribute Changes
     None

@jonathanmendez jonathanmendez merged commit 03f5f31 into main Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jasonmreding jasonmreding jasonmreding approved these changes

@dixonjoel dixonjoel dixonjoel approved these changes

@aepete aepete Awaiting requested review from aepete aepete is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathanmendez @dixonjoel @aepete @jasonmreding