Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition reading the MechAction property to not be read at runtime #516

Merged
merged 2 commits into from
May 16, 2024

Conversation

dixonjoel
Copy link
Collaborator

@dixonjoel dixonjoel commented May 15, 2024

  • This contribution adheres to CONTRIBUTING.md. (Required)
  • Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

Fixes AB#2738336

When a measurement was built into an executable with the 2.2.0.1 prerelease, it would launch briefly and then the .exe would go away. The error turned out to be attempting to read the 'MechAction' property to see if the user was using any latched booleans. We already check this at edit time with Run Service.vi and at build time of the .exe. So I'm disabling this check in the run time engine.

Why should this Pull Request be merged?

Allows measurement services to be built into .exes, a basic requirement of the framework.

What testing has been done?

I will build the .vip files locally in preparation for a prerelease to be made soon and test the built .exe case.

Copy link

0 of 1 files processed successfully.
Processed Is Latched Boolean.vi: ERROR 1
Error 1 occurred at Check Data Size.vi

Possible reason(s):

LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.

Command requires GPIB Controller to be Controller-In-Charge.

Complete call chain:
     Check Data Size.vi
     Write PNG File.vi
     Graphical Diff.lvlib:Merge Diff Images.vi
     Graphical Diff.lvlib:Process Diff Images.vi
     Graphical Diff.lvlib:run_diff.vi
     RunVI.lvclass:RunOperation.vi:5910001
     CoreOperation.lvclass:CallRunOperation.vi:4230002
     ExecuteRunOperation.vi:5250001
     ExecuteOperation.vi:6900002
     ExecuteOperation.vi.ProxyCaller
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Helpers/Is Latched Boolean.vi.
Attribute Changes
     None

Copy link

0 of 1 files processed successfully.
Processed Is Latched Boolean.vi: ERROR 1
Error 1 occurred at Check Data Size.vi

Possible reason(s):

LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.

Command requires GPIB Controller to be Controller-In-Charge.

Complete call chain:
     Check Data Size.vi
     Write PNG File.vi
     Graphical Diff.lvlib:Merge Diff Images.vi
     Graphical Diff.lvlib:Process Diff Images.vi
     Graphical Diff.lvlib:run_diff.vi
     RunVI.lvclass:RunOperation.vi:5910001
     CoreOperation.lvclass:CallRunOperation.vi:4230002
     ExecuteRunOperation.vi:5250001
     ExecuteOperation.vi:6900002
     ExecuteOperation.vi.ProxyCaller
Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Helpers/Is Latched Boolean.vi.
Attribute Changes
     None

@dixonjoel
Copy link
Collaborator Author

0 of 1 files processed successfully. Processed Is Latched Boolean.vi: ERROR 1 Error 1 occurred at Check Data Size.vi

Possible reason(s):

LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.

Command requires GPIB Controller to be Controller-In-Charge.

Complete call chain:      Check Data Size.vi      Write PNG File.vi      Graphical Diff.lvlib:Merge Diff Images.vi      Graphical Diff.lvlib:Process Diff Images.vi      Graphical Diff.lvlib:run_diff.vi      RunVI.lvclass:RunOperation.vi:5910001      CoreOperation.lvclass:CallRunOperation.vi:4230002      ExecuteRunOperation.vi:5250001      ExecuteOperation.vi:6900002      ExecuteOperation.vi.ProxyCaller Diff images generated for Source/Runtime/MeasurementLink Measurement Server/Helpers/Is Latched Boolean.vi. Attribute Changes      None

@aepete any idea why this is not working? It's not a big deal for me in this case, but maybe you could take a look.

@dixonjoel dixonjoel merged commit 979cdec into main May 16, 2024
6 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/fix-measurement-service-exe branch May 16, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants