Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .measui from the DCPower example project #527

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

dixonjoel
Copy link
Collaborator

  • This contribution adheres to CONTRIBUTING.md. (Required)
  • Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

Fixes AB#2761224 where the DCPower example won't build after installation. The relative path is changed during the VIPM build. Removing the .measui from the example.

Why should this Pull Request be merged?

Fixes the example and allows it to be built into a .exe.

What testing has been done?

Installed the newly built package to ensure I could build a .exe.

@MounikaBattu17
Copy link
Contributor

@dixonjoel Currently the PR checks are failing because of the repository name change to measurementlink-plugin-labview. We have hardcoded python scripts path in workflow files. So, they also need to be updated with the repo name change. I can create a small PR & check in the changes now.

@dixonjoel
Copy link
Collaborator Author

@dixonjoel Currently the PR checks are failing because of the repository name change to measurementlink-plugin-labview. We have hardcoded python scripts path in workflow files. So, they also need to be updated with the repo name change. I can create a small PR & check in the changes now.

@MounikaBattu17 that would be great. Let me know if you're done working for the week and I can do it.

@MounikaBattu17
Copy link
Contributor

@MounikaBattu17 that would be great. Let me know if you're done working for the week and I can do it.

@dixonjoel I have created a PR for this issue. Kindly review.
#528

Copy link

github-actions bot commented Jun 9, 2024

0 of 1 files processed successfully.
Processed Get UI Details.vi: ERROR 1
Error 1 occurred at Check Data Size.vi

Possible reason(s):

LabVIEW: (Hex 0x1) An input parameter is invalid. For example if the input is a path, the path might contain a character not allowed by the OS such as ? or @.

Command requires GPIB Controller to be Controller-In-Charge.

Complete call chain:
     Check Data Size.vi
     Write PNG File.vi
     Graphical Diff.lvlib:Merge Diff Images.vi
     Graphical Diff.lvlib:Process Diff Images.vi
     Graphical Diff.lvlib:run_diff.vi
     RunVI.lvclass:RunOperation.vi:5910001
     CoreOperation.lvclass:CallRunOperation.vi:4230002
     ExecuteRunOperation.vi:5250001
     ExecuteOperation.vi:6900002
     ExecuteOperation.vi.ProxyCaller
Diff images generated for Source/Example Measurements/NI-DCPower Source DC Voltage/NI-DCPower Measurement/Get UI Details.vi.
Attribute Changes
     None

@dixonjoel dixonjoel merged commit 1f8584f into main Jun 10, 2024
6 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/remove-measui-second-attempt branch June 10, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants