Remove #MeasurementTodo labels from the configuration and results typedefs #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source/Generator/Measurement Plug-In Template/Measurement/Measurement Logic.vi
Show resolved
Hide resolved
jasonmreding
approved these changes
Jul 11, 2024
dixonjoel
changed the title
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Fixes #560
Remove the labels from the measurement configuration and results typedefs. They made it impossible to delete those "#Todo" labels from Measurement Logic.vi.
Why should this Pull Request be merged?
Bad user experience from the template. Also, the MeasurementLogic.vi already had a comment (which I slightly reworded) on the block diagram explaining the need to update configuration and results.
What testing has been done?
None. Simple cosmetic change and the PR should cover it.