-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ni-apis as submodule and regenerate discovery client LabVIEW code #579
Conversation
I'm not super fluent with submodules, but I think everything under the ni-apis folder comes directly from that repo and is showing because you're adding the submodule? So I think we don't need to review anything under there? |
@pakdev Waiting to approve until the checks all pass. |
That looks wrong. When you added ni-apis as a submodule to measurement-plugin-python, GitHub displayed the submodule as a link and didn't display all of the files inside. |
Right |
On second look, it appears I shouldn't have pushed the contents. I'll fix that |
d01046c
to
942d833
Compare
Source/Tests/Tests.Runtime/Measurement Server/Discovery/Fake Resolve Service.vi
Show resolved
Hide resolved
942d833
to
f817d3c
Compare
f817d3c
to
555e9b7
Compare
Not sure what's going on with these tests - might need some help tomorrow morning. Not able to reproduce these 1003 errors in my branch... |
Passing now |
This reverts commit 3314a9a.
What does this Pull Request accomplish?
The discovery_service.proto in the ni-apis repo is more updated than the one here. For an upcoming change, I wanted the ServiceDescriptor.versions property. Thus, I added ni-apis/protobuf as submodules and regenerated the LabVIEW gRPC bindings from the new proto files.
Why should this Pull Request be merged?
Because our proto files should stay up-to-date and our discovery client LabVIEW code is now up-to-date.
What testing has been done?
Ran run_tests.vi