Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update third_party/protobuf digest to 6ed0b9f #582

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 30, 2024

This PR contains the following updates:

Package Update Change
third_party/protobuf digest ee9c176 -> 6ed0b9f

Configuration

📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title chore(deps): update third_party/protobuf digest to a724fea chore(deps): update third_party/protobuf digest to 7c8ce77 Aug 30, 2024
@renovate renovate bot force-pushed the users/renovate/third_party-protobuf-digest branch from b6c0309 to c84fa89 Compare August 30, 2024 19:06
@bkeryan
Copy link
Collaborator

bkeryan commented Aug 30, 2024

I have a fix for the Renovate scheduling: #586

@dixonjoel
Copy link
Collaborator

This is an improvement over getting an update for each commit. So I suggest we check this in for now and discuss further.

@jasonmreding and I discussed this and I think we're of the same mind that we want to just turn off auto-updating altogether for the ni-apis repo (and maybe the protobuf). The reason for this is we don't have an automated way to generate stubs and / or check for out-of-date stubs like Python does. So if we auto-update, we'll have .proto files that don't match the generated code.

@bkeryan
Copy link
Collaborator

bkeryan commented Aug 30, 2024

This is an improvement over getting an update for each commit. So I suggest we check this in for now and discuss further.

@jasonmreding and I discussed this and I think we're of the same mind that we want to just turn off auto-updating altogether for the ni-apis repo (and maybe the protobuf). The reason for this is we don't have an automated way to generate stubs and / or check for out-of-date stubs like Python does. So if we auto-update, we'll have .proto files that don't match the generated code.

Okay, I'll configure it not to create PRs automatically.

@renovate renovate bot changed the title chore(deps): update third_party/protobuf digest to 7c8ce77 chore(deps): update third_party/protobuf digest to 593bcfa Aug 30, 2024
@renovate renovate bot force-pushed the users/renovate/third_party-protobuf-digest branch from c84fa89 to c7c346f Compare August 30, 2024 21:21
@renovate renovate bot changed the title chore(deps): update third_party/protobuf digest to 593bcfa chore(deps): update third_party/protobuf digest to e4449ba Aug 31, 2024
@renovate renovate bot force-pushed the users/renovate/third_party-protobuf-digest branch from c7c346f to 8affbcc Compare August 31, 2024 00:37
@renovate renovate bot changed the title chore(deps): update third_party/protobuf digest to e4449ba chore(deps): update third_party/protobuf digest to e490bff Aug 31, 2024
@renovate renovate bot force-pushed the users/renovate/third_party-protobuf-digest branch from 8affbcc to 8118615 Compare August 31, 2024 04:39
@renovate renovate bot changed the title chore(deps): update third_party/protobuf digest to e490bff chore(deps): update third_party/protobuf digest to 2f9e150 Aug 31, 2024
@renovate renovate bot force-pushed the users/renovate/third_party-protobuf-digest branch from 8118615 to 1bccabc Compare August 31, 2024 08:12
@renovate renovate bot changed the title chore(deps): update third_party/protobuf digest to 2f9e150 chore(deps): update third_party/protobuf digest to b915e9f Aug 31, 2024
@renovate renovate bot force-pushed the users/renovate/third_party-protobuf-digest branch from 1bccabc to 99ef1dc Compare August 31, 2024 16:13
@renovate renovate bot changed the title chore(deps): update third_party/protobuf digest to b915e9f chore(deps): update third_party/protobuf digest to 6ed0b9f Sep 2, 2024
@renovate renovate bot force-pushed the users/renovate/third_party-protobuf-digest branch from 99ef1dc to 903a922 Compare September 2, 2024 12:10
@dixonjoel dixonjoel merged commit d16c818 into main Sep 3, 2024
5 checks passed
@dixonjoel dixonjoel deleted the users/renovate/third_party-protobuf-digest branch September 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants