Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decouple code generated gRPC server and client API libraries of V2 Measurement Service #587

Merged

Conversation

varshini-senthil
Copy link
Contributor

  • This contribution adheres to CONTRIBUTING.md. (Required)
  • Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

  • Decoupled the code generated gRPC client library Measurement Service Client.lvlib from the server library ni.measurementlink.measurement.v2.api.lvlib of V2 Measurement Service.

    • This is done to fix the issue with loading the child client library Measurement Service Client.lvlib when a Measurement Plug-In Client is created in a new project, which sets the cursor icon to busy icon.
    • This issue arises as LabVIEW tries to load the parent server library ni.measurementlink.measurement.v2.api.lvlib as dependency, while created client only uses the APIs in child client library Measurement Service Client.lvlib.

    Issue

  • Updated Regenerating Server and Client.md to reflect the changes.

Why should this Pull Request be merged?

  • To decouple the gRPC generated client and server API libraries to resolve the issue with loading the client API library Measurement Service Client.lvlib as dependency in the LabVIEW project.

What testing has been done?

  • Created measurement plug-in client in a new LabVIEW project and tested.

@varshini-senthil varshini-senthil merged commit a11fd49 into main Sep 6, 2024
5 checks passed
@varshini-senthil varshini-senthil deleted the users/varshini/separate-client-server-libraries branch September 6, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants