Use measurement's version while writing serviceconfig and registering #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakdev
requested review from
dixonjoel,
aepete and
jasonmreding
as code owners
pakdev
commented
Sep 3, 2024
pakdev
commented
Sep 3, 2024
dixonjoel
approved these changes
Sep 3, 2024
jasonmreding
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
We've recently added version support to the .serviceconfig parser and DiscoveryService. To leverage this new functionality, this PR uses the existing version from
Get Measurement Details.viwhen writing the *.serviceconfig file and registering with DiscoveryService:Why should this Pull Request be merged?
We want to have versioned measurements.
What testing has been done?
Generated a new plug-in with these updates and confirmed the new *.serviceconfig file contains
"version": "x.x.x"and DiscoveryService receives the same version inRegisterService.