Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] update: generate error if case not found for a given control name #591

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

varshini-senthil
Copy link
Contributor

  • This contribution adheres to CONTRIBUTING.md. (Required)
  • Automatically post PR comments with images for G code changes? (Recommended for small changes)

What does this Pull Request accomplish?

  • Added custom error string in the global variable VI Error Strings Global Internal.vi, to indicate that no case exists for the given control name in Update Control from Metadata.vi.
    • This update is to alert the user about the change in control name in the Client template through error generation.

Why should this Pull Request be merged?

  • To update the global variable VI Error Strings Global Internal.vi.
  • To update the Update Control from Metadata.vi, to generate error when no case found for the given control name.

What testing has been done?

  • Modified the measurement plug-in client template and tested error generation by creating a client.

@varshini-senthil varshini-senthil changed the title [minor] update: generate error for case not found [minor] update: generate error if case not found for a given control name Sep 16, 2024
Copy link
Contributor

@jasonmreding jasonmreding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to remove dependency on error file used by runtime libraries.

@varshini-senthil varshini-senthil force-pushed the users/varshini/control-case-not-found-error branch from 0724ac3 to 3bac570 Compare September 19, 2024 06:44
@varshini-senthil varshini-senthil merged commit 10cf479 into main Sep 19, 2024
5 checks passed
@varshini-senthil varshini-senthil deleted the users/varshini/control-case-not-found-error branch September 19, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants