-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the TestStand sequence of NI DCPower measurement to make it simpler #249
Conversation
…the pin map and session registration steps Signed-off-by: Tharun Sundar Balasubramanian <tharun.balasubramanian@ni.com>
Signed-off-by: Tharun Sundar Balasubramanian <tharun.balasubramanian@ni.com>
@bkeryan When executing the TestStand sequence, the pin map file is not found even if it is available in the sequence directory. I updated the code as shown below to make sure that the logic is similar to the LabVIEW example sequence.
But it is not having any impact in the search. Please share your thoughts on this. |
examples/nidcpower_source_dc_voltage/NIDCPowerSourceDCVoltage.seq
Outdated
Show resolved
Hide resolved
The first time you call
When you call The problem is that Passing
Using keyword arguments allows us to leave Let's do this:
|
Signed-off-by: Brad Keryan <brad.keryan@ni.com>
Signed-off-by: Brad Keryan <brad.keryan@ni.com>
Signed-off-by: Brad Keryan <brad.keryan@ni.com>
Signed-off-by: Brad Keryan <brad.keryan@ni.com>
Signed-off-by: Brad Keryan <brad.keryan@ni.com>
…impler (#249) * Updated the TestStand sequence of NI DCPower measurement to simplify the pin map and session registration steps Signed-off-by: Tharun Sundar Balasubramanian <tharun.balasubramanian@ni.com> * Fix lint errors Signed-off-by: Tharun Sundar Balasubramanian <tharun.balasubramanian@ni.com> * Add new function to get pin map id stored in temporary variable * Pass searchcontext with sequence file path * Update python adaptoer consistently * Resolve PR comments * Specifies the return type for COM object * File formatted using black * examples: Update type annotations and docstrings Signed-off-by: Brad Keryan <brad.keryan@ni.com> * examples: Rename TestStandSupport methods Signed-off-by: Brad Keryan <brad.keryan@ni.com> * examples: Fix resolve_file_path Signed-off-by: Brad Keryan <brad.keryan@ni.com> * examples: Uncheck "Use adapter settings for Python interpreter" Signed-off-by: Brad Keryan <brad.keryan@ni.com> * examples: Update PinMapClient naming/comments Signed-off-by: Brad Keryan <brad.keryan@ni.com> --------- Signed-off-by: Tharun Sundar Balasubramanian <tharun.balasubramanian@ni.com> Signed-off-by: Brad Keryan <brad.keryan@ni.com> Co-authored-by: Vikram Avudaiappan <vikram.avudaiappan@ni.com> Co-authored-by: Brad Keryan <brad.keryan@ni.com>
What does this Pull Request accomplish?
Why should this Pull Request be merged?
Based on the feedback discussed in this Teams post, moving the process setup and process cleanup steps to the main sequence will simplify the example sequence as the user will only need to run the main sequence to get the expected result. Though this sequence is not efficient for multi-site use case, this change is encouraged as the example sequence is expected to be tailored to users who are beginners in TestStand.
What testing has been done?
Manually executed the TestStand example sequence with a simulated DC-Power instrument and verified the result.