-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: Add _helpers.py file to non-driver examples and update acceptance tests #329
Conversation
Driver examples are updated with _helpers.py file to match template Hence updating the other examples to use _helpers.py Signed-off-by: Vikram Avudaiappan <vikram.avudaiappan@ni.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could go either way on whether we should include these, but I have no strong objection to doing it. I'd wait for @bkeryan to chime in before submitting.
Updating these examples to use If you want to use |
All the checks passed for this PR. Did you expect them to break? In what way does _helpers.py cause them to break? |
This PR doesn't update the examples to use If you update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to use _helpers.py in all the examples, you should update the tests to use their own services instead of running the examples.
@bkeryan I have added fake measurement_service (copied details from example measurements). Also, update acceptance tests to use fake measurement_service instead of running examples.
…nto users/vikram/add-helpers-non-driver-examples
…e sample measurements
What does this Pull Request accomplish?
_helpers.py
to the example measurements:sample_measurement
sample_streaming_measurement
ui_progress_updates
Why should this Pull Request be merged?
_helpers.py
file generated, but when they refer the example measurements they might not see_helpers.py
file._helpers.py
file to match template. Hence, updating the other examples to use_helpers.py
What testing has been done?
_helpers.py
and Ranpoetry run pytest
to verify all tests passed.