service: Fix mypy errors with types-protobuf 4.24 #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Fix these mypy errors:
This code has separate cases for
EnumTypeWrapper
andEnum
, and these errors occur when mypy type-checks theEnum
case using the_EnumTypeWrapper[_V]
type.EnumTypeWrapper
is not a subclass oftype
, but types-protobuf 4.24 now pretends that_EnumTypeWrapper[_V]
inherits fromtype
: https://www.github.com/python/typeshed/pull/10203This seems to affect the type narrowing in
_enum_to_annotations_value
.isinstance(enum_type, type)
previously rejectedEnumTypeWrapper
, but now accepts it.and issubclass(enum_type, Enum)
should still rejectEnumTypeWrapper
, but apparently it doesn't. This may be related to the limitations described in https://www.github.com/python/mypy/issues/15653Anyway,
isinstance(enum_type, EnumMeta)
works at run time and with mypy.Related improvements:
TypeGuard
to simplify type narrowing.typing_extensions
at run time.Why should this Pull Request be merged?
Updating poetry.lock causes mypy errors.
What testing has been done?
Ran mypy and pytest.