[releases/1.2] Fix the discovery service to not terminate on parent process closure #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent console process
samchris007
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
bkeryan,
mshafer-NI and
nstokes-nati
as code owners
samchris007
changed the title
dixonjoel
approved these changes
Sep 21, 2023
…arentprocessclosure
bkeryan
approved these changes
Sep 21, 2023
Tharun-Sundar
approved these changes
Sep 21, 2023
dixonjoel
deleted the
users/sam/fixdiscovery-termination-parentprocessclosure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Cherry-pick change to fix the issue with the discovery service termination when terminating/closing the measurement service #383
Why should this Pull Request be merged?
Fixes Bug 2508628: Python measurements - Discovery service is not completely detached from VSCode console/terminal and terminates on terminal closure