Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing measured value indicator to use significant digits instead of digits of precision #420

Merged
merged 5 commits into from
Sep 28, 2023
Merged

Changing measured value indicator to use significant digits instead of digits of precision #420

merged 5 commits into from
Sep 28, 2023

Conversation

DelpireNI
Copy link
Contributor

@DelpireNI DelpireNI commented Sep 26, 2023 •
edited
Loading

What does this Pull Request accomplish?

  • Changes NI VISA DMM, NI DMM, Output Measurement Voltage examples' measui's "Measured value" indicator to use significant digits instead of digits of precision.
  • They will have 7 significant digits.
  • Updated width of indicators so that 7 digits and the E+XX fit well.
  • Ensured left and right margins were the same.
  • Updated output voltage measurement example so that the measurement voltage indicator is aligned vertically with the inputs.

Here is a demonstration of the issue:
image

Here are the updated UI in InstrumentStudio:
NI-VISA DMM
image

NI-DMM
image

Output Voltage Measurement:
image

Why should this Pull Request be merged?

See (#410)
Very large numbers take up too much space. It would be better to use scientific notation which the significant digits setting does.

What testing has been done?

Ran example in the measui editor.
Updated python measurement to force it to return huge number. Huge numbers are now in scientific notation.

@DelpireNI
Changing measured value indicator to use digitals of precision instea…
8a91d27 
…d of significant digits.

Signed-off-by: Chris Delpire <chris.delpire@ni.com>
@DelpireNI
Meant to use significant digits.
010a207 
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
@dixonjoel dixonjoel changed the title Changing measured value indicator to use significant digitals instead of digitals of precision. Changing measured value indicator to use significant digits instead of digits of precision Sep 26, 2023
@github-actions
Copy link

github-actions bot commented Sep 26, 2023 •
edited
Loading

Test Results

     12 files  ±0       12 suites  ±0   2m 20s ⏱️ -2s
   217 tests ±0     188 ✔️ ±0    29 💤 ±0  0 ❌ ±0 
2 592 runs  ±0  2 228 ✔️ ±0  364 💤 ±0  0 ❌ ±0 

Results for commit 4029cdb. ± Comparison against base commit e3ca3fb.

♻️ This comment has been updated with latest results.

@DelpireNI
Increasing significant digits to 7. Increase size of the box. Ensurin…
0d0fc77 
…g margins on left and right are the same.

Signed-off-by: Chris Delpire <chris.delpire@ni.com>
@DelpireNI
Updating DMM and Output Voltage examples to use significant digits wi…
1686678 
…th 7 digits.

Signed-off-by: Chris Delpire <chris.delpire@ni.com>
@DelpireNI
Increasing indicator size.
4029cdb 
Signed-off-by: Chris Delpire <chris.delpire@ni.com>
@DelpireNI DelpireNI merged commit 104cd34 into main Sep 28, 2023
17 checks passed
@DelpireNI DelpireNI deleted the users/cdelpire/update-visa-dmm-example-measui branch September 28, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixonjoel dixonjoel dixonjoel approved these changes

@bkeryan bkeryan bkeryan approved these changes

@csjall csjall Awaiting requested review from csjall csjall is a code owner

@pbirkhol-ni pbirkhol-ni Awaiting requested review from pbirkhol-ni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DelpireNI @bkeryan @dixonjoel