service: Add _configuration submodule #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeryan
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
|
FYI @cfuentes-ni @rfriedma: This is my proposed replacement for the |
dixonjoel
approved these changes
Sep 29, 2023
cfuentes-ni
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add a
_configurationsubmodule, which reads configuration options from the environment or a.envfile. In later PRs, this will be used to replace the examples' command-line parameters andServiceOptionsclass.Update
_featuretogglesto share the python-decoupleAutoConfigwith_configuration.Why should this Pull Request be merged?
The new create_session(s) API will use this.
What testing has been done?
Ran mypy and new unit tests.