service: Fix session type checks #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patching the Session class and replacing it with a Mock doesn't work with isinstance() because an instance of Mock is not a type.
_with_typed_session() was incorrectly assuming that the runtime type matches the static type. Also, it was trying to infer the static type variable `TSession` based on the runtime type expression `type(session)`.
bkeryan
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
mshafer-NI and
nstokes-nati
as code owners
bkeryan
commented
Oct 7, 2023
dixonjoel
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
_with_typed_session()was incorrectly assuming that the runtime type matches the static type. Also, it was trying to infer the static type variableTSessionbased on the runtime type expressiontype(session).Fixing this revealed a problem with the tests: patching
driver.Sessionand replacing it with a mock causesisinstancechecks to fail. The 2nd argument toisinstancemust be a type, so it raises an error ifdriver.Sessionis aMockinstance rather than a type. Patchingdriver.Session.__new__instead ofdriver.Sessionavoids this problem because it ensures thatdriver.Sessionis still a type. (Patchingdriver.Sessionto replace it with a subclass that overrides__new__would also work.)Why should this Pull Request be merged?
These type checks are needed for
get_connection(s)What testing has been done?
Ran updated unit tests.